Add fallible version of the digital traits and deprecate the current ones#108
Conversation
eldruin
requested review from
a team,
ilya-epifanov and
thejpster
as code owners
therealprof
left a comment
therealprof
left a comment
There was a problem hiding this comment.
LGTM! Thanks very much for keeping at it.
|
@hannobraun @ryankurte Are you okay with this? |
|
@rust-embedded/hal Any other opinions? |
There was a problem hiding this comment.
(Sorry, accidentally submitted this comment early. I edited it to complete it.)
It's possible to add additional information to #[deprecated], namely the version since when something has been deprecated, and a note that is going to be part of the compiler warning (I think). This is documented here: https://doc.rust-lang.org/reference/attributes.html
It would be nice to have this, but I'm fine merging this pull request without.
hannobraun
left a comment
hannobraun
left a comment
There was a problem hiding this comment.
Sorry, I meant to approve this pull request, but accidentally submitted my comment before it was complete. See my other comment for a note on a nice-to-have item.
Thank you @eldruin for sticking with this! I know working on this project is not easy :)
hannobraun
left a comment
hannobraun
left a comment
There was a problem hiding this comment.
Thank you again, @eldruin! You're really going above and beyond what can reasonably be expected. I really appreciate it!
|
Is there anything missing here? |
|
We still need adapter traits (see #100 for examples) before we release, but I'll merge this for now. bors r+ |
|
👎 Rejected by label |
|
Oops, @therealprof are you still happy with this? |
|
@ryankurte Yepp, I'm good. Needs conflict resolution, though. |
ryankurte
dismissed stale reviews from therealprof, hannobraun, and themself
via
14cac99
|
bors r+ |
|
👎 Rejected by too few approved reviews |
|
whoops bors r+ |
108: Add fallible version of the digital traits and deprecate the current ones r=ryankurte a=eldruin There seems to be an agreement in [#100](#100 (comment)) on how to proceed with the fallible traits. This adds the fallible traits under `digital::v2` and marks the current ones as deprecated. Co-authored-by: Diego Barrios Romero <eldruin@gmail.com> Co-authored-by: Ryan <ryankurte@users.noreply.github.com>
Build failed |
|
Funny complaints from the nightly compiler. 👎 @rust-embedded/resources Should we make the nightly compiler builds informal only, i.e. not fail CI? Our main target is beta/stable anyways. |
|
This might be because two of the doc tests rely on nightly features (https://github.com/rust-embedded/embedded-hal/blob/master/src/lib.rs#L385 ++ and https://github.com/rust-embedded/embedded-hal/blob/master/src/lib.rs#L557 ++). Maybe the doc test for these two should be tagged with the but either way the failed doc test doesn't have anything to do with this PR. |
|
bors try |
tryBuild succeeded |
|
bors r+ |
108: Add fallible version of the digital traits and deprecate the current ones r=ryankurte a=eldruin There seems to be an agreement in [#100](#100 (comment)) on how to proceed with the fallible traits. This adds the fallible traits under `digital::v2` and marks the current ones as deprecated. Co-authored-by: Diego Barrios Romero <eldruin@gmail.com> Co-authored-by: Ryan <ryankurte@users.noreply.github.com>
Build succeeded |
5 participants
There seems to be an agreement in #100 on how to proceed with the fallible traits.
This adds the fallible traits under
digital::v2and marks the current ones as deprecated.This solves #95